Snow-kal commented on code in PR #1107:
URL: https://github.com/apache/dubbo-go-samples/pull/1107#discussion_r3254051672


##########
metrics/probe/deploy/server-deployment.yml:
##########
@@ -14,10 +14,18 @@ spec:
       labels:
         app: dubbo-go-probe-server
     spec:
+      terminationGracePeriodSeconds: 15
       containers:
         - name: server
           image: dubbo-go-probe-server:latest
           imagePullPolicy: IfNotPresent
+          resources:
+            requests:
+              cpu: 100m
+              memory: 128Mi
+            limits:
+              cpu: 500m
+              memory: 512Mi

Review Comment:
   主要是来避免容器没有资源边界
   requests 限制最低资源需求 
   imits 表示容器运行时最多可使用的资源上限
   
   当然如果觉得不是很稳妥的话 可以把这个 server-deployment.yml 回到原来版本 没啥影响



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to