Alanxtl commented on code in PR #3335:
URL: https://github.com/apache/dubbo-go/pull/3335#discussion_r3271262636
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -144,7 +144,7 @@ func (f *consumerGracefulShutdownFilter)
isClosingInvoker(invoker base.Invoker)
f.closingInvokers.Delete(key)
if setter, ok := invoker.(base.AvailabilitySetter); ok {
setter.SetAvailable(true)
- logger.Infof("Graceful shutdown --- Recovered invoker
availability after closing TTL --- %s", key)
+ logger.Infof("[Filter][GracefulShutdown] Graceful
shutdown, recovered invoker availability after closing TTL, key=%s", key)
Review Comment:
```suggestion
logger.Infof("[Filter][GracefulShutdown] recovered
invoker availability after closing TTL, key=%s", key)
```
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -168,12 +168,12 @@ func (f *consumerGracefulShutdownFilter)
markClosingInvoker(invoker base.Invoker
expireTime := time.Now().Add(f.getClosingInvokerExpireTime())
f.closingInvokers.Store(key, expireTime)
- logger.Infof("Graceful shutdown --- Marked invoker as closing --- %s,
will expire at %v, IsAvailable=%v",
+ logger.Infof("[Filter][GracefulShutdown] Graceful shutdown, marked
invoker as closing, key=%s expireTime=%v isAvailable=%v",
key, expireTime, invoker.IsAvailable())
if setter, ok := invoker.(base.AvailabilitySetter); ok {
setter.SetAvailable(false)
- logger.Infof("Graceful shutdown --- Set invoker unavailable ---
%s, IsAvailable now=%v",
+ logger.Infof("[Filter][GracefulShutdown] Graceful shutdown, set
invoker unavailable, key=%s isAvailable=%v",
Review Comment:
```suggestion
logger.Infof("[Filter][GracefulShutdown] set invoker
unavailable, key=%s isAvailable=%v",
```
##########
filter/handler/rejected_execution_handler_only_log.go:
##########
@@ -71,7 +71,7 @@ type OnlyLogRejectedExecutionHandler struct{}
func (handler *OnlyLogRejectedExecutionHandler) RejectedExecution(url
*common.URL,
_ base.Invocation) result.Result {
- logger.Errorf("The invocation was rejected. url: %s", url.String())
+ logger.Errorf("[Filter][Handler] The invocation was rejected, url=%s",
url.String())
Review Comment:
```suggestion
logger.Errorf("[Filter][Handler] the invocation was rejected, url=%s",
url.String())
```
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -80,7 +80,7 @@ func newConsumerGracefulShutdownFilter() filter.Filter {
func (f *consumerGracefulShutdownFilter) Invoke(ctx context.Context, invoker
base.Invoker, invocation base.Invocation) result.Result {
// check if invoker is closing
if f.isClosingInvoker(invoker) {
- logger.Warnf("Graceful shutdown --- Skipping closing invoker
--- %s", invoker.GetURL().String())
+ logger.Warnf("[Filter][GracefulShutdown] Graceful shutdown,
skipping closing invoker, url=%s", invoker.GetURL().String())
Review Comment:
```suggestion
logger.Warnf("[Filter][GracefulShutdown] skipping closing
invoker, url=%s", invoker.GetURL().String())
```
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -168,12 +168,12 @@ func (f *consumerGracefulShutdownFilter)
markClosingInvoker(invoker base.Invoker
expireTime := time.Now().Add(f.getClosingInvokerExpireTime())
f.closingInvokers.Store(key, expireTime)
- logger.Infof("Graceful shutdown --- Marked invoker as closing --- %s,
will expire at %v, IsAvailable=%v",
+ logger.Infof("[Filter][GracefulShutdown] Graceful shutdown, marked
invoker as closing, key=%s expireTime=%v isAvailable=%v",
Review Comment:
```suggestion
logger.Infof("[Filter][GracefulShutdown] marked invoker as closing,
key=%s expireTime=%v isAvailable=%v",
```
##########
filter/tps/limiter/method_service.go:
##########
@@ -191,8 +190,8 @@ func getLimitConfig(methodLevelConfig string,
if len(methodLevelConfig) > 0 {
result, err := strconv.ParseInt(methodLevelConfig, 0, 0)
if err != nil {
- logger.Error(fmt.Sprintf("The %s for invocation %s # %s
must be positive, please check your configuration!",
- configKey, url.ServiceKey(),
invocation.MethodName()))
+ logger.Errorf("[Filter][TPS] The %s for invocation must
be positive, please check your configuration, configKey=%s serviceKey=%s
methodName=%s",
Review Comment:
```suggestion
logger.Errorf("[Filter][TPS] the %s for invocation must
be positive, please check your configuration, configKey=%s serviceKey=%s
methodName=%s",
```
首字母大小写这个事情统一一下
##########
filter/polaris/limit/limiter.go:
##########
@@ -46,27 +46,27 @@ type polarisTpsLimiter struct {
func (pl *polarisTpsLimiter) IsAllowable(url *common.URL, invocation
base.Invocation) bool {
if err := remotingpolaris.Check(); errors.Is(err,
remotingpolaris.ErrorNoOpenPolarisAbility) {
- logger.Debug("[TpsLimiter][Polaris] not open polaris ratelimit
ability")
+ logger.Debug("[Filter][Polaris] not open polaris ratelimit
ability")
Review Comment:
```suggestion
logger.Debug("[Filter][Polaris][TPS] not open polaris ratelimit
ability")
```
这个文件都改成这样
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
