mochengqian opened a new pull request, #946: URL: https://github.com/apache/dubbo-go-pixiu/pull/946
## What Follow up on #928 after running newer golangci-lint checks. Switch the Maglev SHA3 imports from `golang.org/x/crypto/sha3` to the standard library `crypto/sha3`. ## Why `golangci-lint` 2.12.2 enables the `govet` inline analyzer. Recent `golang.org/x/crypto/sha3` wrappers carry `//go:fix inline` directives pointing callers to the standard library SHA3 package, so the new benchmark code was reported as: ```text inline: Call of sha3.Sum512 should be inlined ``` Using `crypto/sha3` directly is the intended migration path and avoids future full-package lint noise in `permutation.go` too. ## Tests - [x] `gofmt -w pkg/cluster/loadbalancer/maglev/permutation.go pkg/cluster/loadbalancer/maglev/permutation_bench_test.go` - [x] `gofmt -s -w pkg/cluster/loadbalancer/maglev/permutation.go pkg/cluster/loadbalancer/maglev/permutation_bench_test.go` - [x] `imports-formatter` - [x] `git diff --check` - [x] `go test ./pkg/cluster/loadbalancer/maglev` - [x] `golangci-lint 2.12.2 run --new-from-rev upstream/develop ./pkg/cluster/loadbalancer/maglev/...` - [x] `golangci-lint 2.12.2 run --new-from-rev origin/develop ./pkg/cluster/loadbalancer/maglev/...` - [x] `go test ./pkg/cluster/loadbalancer/maglev -run '^$' -bench 'BenchmarkLookUpTable(Hash|Get)$' -benchtime=100ms` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
