mochengqian commented on PR #928: URL: https://github.com/apache/dubbo-go-pixiu/pull/928#issuecomment-4531128025
> 补跑 golangci-lint 2.12.2 后发现新增 lint 问题，需要先修改： > > * [P1] pkg/cluster/loadbalancer/maglev/permutation_bench_test.go:1：`golangci-lint run --new-from-rev origin/develop ./pkg/cluster/loadbalancer/maglev/...`报`gofmt`：文件格式不正确。请先按仓库仓库规则重新生成该文件；当前看起来主要是行尾格式导致gofmt认为整个文件不一致。 > * [P2] pkg/cluster/loadbalancer/maglev/permutation_bench_test.go:85：`govet`报告`inline: Call of sha3.Sum512 should be inlined`。这里是基准测试助手，可以按兽医建议把调用直接内联到返回表达式或调整写法，确保通过 linter 添加代码。 @AlexStocks 已处理，感谢补跑 lint。 因为 #928 已经合并，我没有继续改原 PR，而是基于最新 `develop` 开了一个最小 follow-up PR：#946。 处理方式： - `permutation_bench_test.go` 已重新 `gofmt` / `imports-formatter` - `sha3.Sum512` 的 lint 根因是 `golang.org/x/crypto/sha3` 新版本 wrapper 带了 `//go:fix inline` - 所以我没有只在 benchmark 里绕写法，而是把 Maglev 相关代码切到标准库 `crypto/sha3`，避免后续全量 lint 继续报同类问题 验证已通过： - `go test ./pkg/cluster/loadbalancer/maglev` - `golangci-lint 2.12.2 run --new-from-rev origin/develop ./pkg/cluster/loadbalancer/maglev/...` - `golangci-lint 2.12.2 run --new-from-rev upstream/develop ./pkg/cluster/loadbalancer/maglev/...` 结果是 `0 issues`。 Follow-up PR: https://github.com/apache/dubbo-go-pixiu/pull/946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
