dongyikuan919 commented on issue #16276: URL: https://github.com/apache/dubbo/issues/16276#issuecomment-4534409513
For tri over Netty, JVM-level `socksProxyHost` is unlikely to help because the connection is not created through JDK socket APIs. Adding a `Socks5ProxyHandler` in the Netty pipeline looks like the right direction. When testing #16285, I would suggest covering at least these cases: 1. direct connection unchanged when no proxy config is present; 2. SOCKS5 connection succeeds for tri unary call; 3. reconnect path still installs the proxy handler after `clearNettyChannel()`; 4. TLS + SOCKS5 ordering is correct, i.e. proxy handshake happens before TLS/HTTP2 handlers start application traffic. The reconnect case is easy to miss here because the TODO is close to the close-future cleanup path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
