Alanxtl commented on code in PR #3344:
URL: https://github.com/apache/dubbo-go/pull/3344#discussion_r3308315333
##########
metadata/report/etcd/report.go:
##########
@@ -119,7 +119,7 @@ func (e *etcdMetadataReportFactory)
CreateMetadataReport(url *common.URL) report
addresses := strings.Split(url.Location, ",")
client, err := gxetcd.NewClient(gxetcd.MetadataETCDV3Client, addresses,
timeout, 1)
if err != nil {
- logger.Errorf("Could not create etcd metadata report. URL:
%s,error:{%v}", url.String(), err)
+ logger.Errorf("[MetadataReport][Etcd] could not create etcd
metadata report, url=%s, err=%v", url.String(), err)
Review Comment:
```suggestion
logger.Errorf("[Metadata][Etcd] could not create etcd metadata
report, url=%s, err=%v", url.String(), err)
```
其他的也都改了
##########
protocol/dubbo/impl/codec.go:
##########
@@ -166,7 +166,7 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
return err
}
if p.IsResponseWithException() {
- logger.Infof("response with exception: %+v", p.Header)
+ logger.Infof("[Dubbo][Impl] response with exception,
header=%v", p.Header)
Review Comment:
```suggestion
logger.Infof("[Dubbo] response with exception, header=%v",
p.Header)
```
其余的都这样
##########
protocol/triple/triple_protocol/protocol_triple.go:
##########
@@ -497,7 +497,7 @@ func (m *tripleUnaryMarshaler) Marshal(message any) *Error {
data, err := m.codec.Marshal(message)
if err != nil {
if m.backupCodec != nil && m.codec.Name() !=
m.backupCodec.Name() {
- logger.Warnf("failed to marshal message with primary
codec %s, trying fallback codec %s", m.codec.Name(), m.backupCodec.Name())
+ logger.Warnf("[Triple][Protocol] failed to marshal
message with primary codec %s, trying fallback codec %s", m.codec.Name(),
m.backupCodec.Name())
Review Comment:
```suggestion
logger.Warnf("[Triple] failed to marshal message with
primary codec %s, trying fallback codec %s", m.codec.Name(),
m.backupCodec.Name())
```
##########
metadata/client.go:
##########
@@ -85,7 +85,7 @@ func (m *triMetadataServiceV2) getMetadataInfo(ctx
context.Context, revision str
inv, _ := generateInvocation(m.invoker.GetURL(), methodName, req,
metadataInfo, constant.CallUnary)
res := m.invoker.Invoke(context.Background(), inv)
if res.Error() != nil {
- logger.Errorf("could not get the metadata info from remote
provider: %v", res.Error())
+ logger.Errorf("[MetadataRPC] could not get the metadata info
from remote provider, err=%v", res.Error())
Review Comment:
```suggestion
logger.Errorf("[Metadata] could not get the metadata info from
remote provider, err=%v", res.Error())
```
其他的也都改
##########
protocol/triple/triple_protocol/protocol_triple.go:
##########
@@ -557,7 +557,7 @@ func (u *tripleUnaryUnmarshaler) Unmarshal(message any)
*Error {
err := u.UnmarshalFunc(message, u.codec.Unmarshal)
if err != nil {
if u.backupCodec != nil && u.codec.Name() !=
u.backupCodec.Name() {
- logger.Warnf("failed to unmarshal message with primary
codec %s, trying fallback codec %s", u.codec.Name(), u.backupCodec.Name())
+ logger.Warnf("[Triple][Protocol] failed to unmarshal
message with primary codec %s, trying fallback codec %s", u.codec.Name(),
u.backupCodec.Name())
Review Comment:
```suggestion
logger.Warnf("[Triple] failed to unmarshal message with
primary codec %s, trying fallback codec %s", u.codec.Name(),
u.backupCodec.Name())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
