mochengqian commented on PR #932:
URL: https://github.com/apache/dubbo-go-pixiu/pull/932#issuecomment-4553800826
> `SetEndpoint` 这条动态注册路径还在按“ID 相等就更新”处理，新的 `-2`
去重规则并没有落到这里。pkg/server/cluster_manager.go 先给空 ID 走
`stableEndpointIDForSet()`，而这个 helper 在发现已有同 hash endpoint 时会直接复用原
ID，pkg/server/cluster_manager.go 随后马上命中更新分支 pkg/server/cluster_manager.go，把旧
endpoint 覆盖掉，而不是生成 `foo-2`/`generated-...-2` 追加进去。我本地在 PR 头上复现过：连续两次
`SetEndpoint("c", &model.Endpoint{Address: ...})`，最终 `len(Endpoints)` 还是
`1`。这会让这次 PR 的“重复 ID 改为后缀去重”只对静态装配生效，对实际的 LLM/Nacos 动态注册路径仍然是静默合并。
good catch, fixed ,thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
