Alanxtl commented on code in PR #3346:
URL: https://github.com/apache/dubbo-go/pull/3346#discussion_r3328500231
##########
registry/mock_registry.go:
##########
@@ -112,7 +112,7 @@ func (r *MockRegistry) Subscribe(url *common.URL,
notifyListener NotifyListener)
return
}
- logger.Infof("[Mock Registry] update begin,
service event: %v", serviceEvent.String())
+ logger.Infof("[Registry] update begin,
event=%v", serviceEvent.String())
Review Comment:
```suggestion
logger.Infof("[Registry][Mock] update begin,
event=%v", serviceEvent.String())
```
其余的都这样
##########
registry/protocol/protocol.go:
##########
@@ -89,7 +89,7 @@ func (proto *registryProtocol) getRegistry(registryUrl
*common.URL) registry.Reg
actualReg, _ := proto.registries.LoadOrStore(cacheKey, func() any {
reg, err := extension.GetRegistry(registryUrl.Protocol,
registryUrl)
if err != nil {
- logger.Errorf("Registry cannot connect successfully.
Error: %s", err.Error())
+ logger.Errorf("[Registry][Protocol] registry cannot
connect successfully, err=%s", err.Error())
Review Comment:
```suggestion
logger.Errorf("[Registry] registry cannot connect
successfully, err=%s", err.Error())
```
其余的都改
##########
registry/exposed_tmp/exposed.go:
##########
@@ -66,7 +66,7 @@ func RegisterServiceInstanceContext(ctx context.Context)
error {
func UnregisterServiceInstance() error {
defer func() {
if err := recover(); err != nil {
- logger.Errorf("unregister service instance
failed,please check if registry protocol is imported, error: %v", err)
+ logger.Errorf("[Registry][Exposed] unregister service
instance failed, please check if registry protocol is imported, err=%v", err)
Review Comment:
```suggestion
logger.Errorf("[Registry] register service instance
failed, please check if registry protocol is imported, err=%v", err)
}
}()
protocol := extension.GetProtocol(constant.RegistryKey)
@@ -66,7 +66,7 @@ func RegisterServiceInstanceContext(ctx context.Context)
error {
func UnregisterServiceInstance() error {
defer func() {
if err := recover(); err != nil {
logger.Errorf("[Registry] unregister service instance
failed, please check if registry protocol is imported, err=%v", err)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
