Copilot commented on code in PR #3360:
URL: https://github.com/apache/dubbo-go/pull/3360#discussion_r3338059906
##########
protocol/rest/config/reader/rest_config_reader.go:
##########
@@ -38,11 +38,9 @@ import (
"dubbo.apache.org/dubbo-go/v3/protocol/rest/config"
)
-const REST = "rest"
-
func init() {
- extension.SetConfigReaders(REST, NewRestConfigReader)
- extension.SetDefaultConfigReader(REST, REST)
+ extension.SetConfigReaders(constant.RESTProtocol, NewRestConfigReader)
+ extension.SetDefaultConfigReader(constant.RESTProtocol,
constant.RESTProtocol)
}
Review Comment:
PR description checklist says tests were added, but this change set only
removes tests (e.g., rest_subscribed_urls_synthesizer_test.go) and does not add
any new coverage. Please update the PR checklist/description to reflect the
actual testing changes, or add appropriate tests if new behavior is intended.
##########
cluster/router/chain/chain.go:
##########
@@ -175,7 +175,7 @@ func NewRouterChain(url *common.URL) (*RouterChain, error) {
routerFactories := extension.GetRouterFactories()
if len(routerFactories) == 0 {
- return nil, perrors.Errorf("No routerFactory exits , create one
please")
+ return nil, perrors.Errorf("No routerFactory exits, create one
please")
Review Comment:
The error message still says "exits" (meaning "leaves") instead of "exists"
(meaning "is present"). This looks like a typo and may confuse users when
router factories are not registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
