RainYuY commented on code in PR #16306:
URL: https://github.com/apache/dubbo/pull/16306#discussion_r3345536870


##########
dubbo-common/src/main/java/org/apache/dubbo/common/utils/CollectionUtils.java:
##########
@@ -419,7 +419,7 @@ public static <T> T first(List<T> values) {
         return values.get(0);
     }
 
-    public static <T> Set<T> toTreeSet(Set<T> set) {
+    public static <T extends Comparable<? super T>> Set<T> toTreeSet(Set<T> 
set) {

Review Comment:
   Have you confirmed that all element types for the toTreeSet calls in the 
Dubbo codebase have implemented Comparable? This looks like an incompatible 
change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to