Skylm808 commented on code in PR #948: URL: https://github.com/apache/dubbo-go-pixiu/pull/948#discussion_r3369027921
########## pkg/filter/http/openapi/openapi.go: ########## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package openapi + +import ( + "bytes" + "io" + "net/http" + "os" + "path/filepath" + "strings" +) + +import ( + "github.com/pb33f/libopenapi" + openapiValidator "github.com/pb33f/libopenapi-validator" + validatorConfig "github.com/pb33f/libopenapi-validator/config" + validatorErrors "github.com/pb33f/libopenapi-validator/errors" + validatorPaths "github.com/pb33f/libopenapi-validator/paths" + validatorRadix "github.com/pb33f/libopenapi-validator/radix" + "github.com/pb33f/libopenapi/datamodel" + v3 "github.com/pb33f/libopenapi/datamodel/high/v3" + + "github.com/pkg/errors" +) + +import ( + "github.com/apache/dubbo-go-pixiu/pkg/common/constant" + "github.com/apache/dubbo-go-pixiu/pkg/common/extension/filter" + contexthttp "github.com/apache/dubbo-go-pixiu/pkg/context/http" + "github.com/apache/dubbo-go-pixiu/pkg/logger" +) + +const ( + // Kind is the kind of OpenAPI validation filter. + Kind = constant.HTTPOpenAPIFilter + + defaultMaxRequestBodyBytes = 1 << 20 +) + +var errOpenAPIRequestBodyTooLarge = errors.New("openapi request body too large") + +func init() { + filter.RegisterHttpFilter(&Plugin{}) +} + +type ( + Plugin struct { + } + + FilterFactory struct { + cfg *Config + validator openapiValidator.Validator + model *v3.Document + validationOptions *validatorConfig.ValidationOptions + maxRequestBody int64 + } + + Filter struct { + validator openapiValidator.Validator + model *v3.Document + validationOptions *validatorConfig.ValidationOptions + maxRequestBody int64 + } + + Config struct { + Path string `yaml:"path" json:"path,omitempty"` + // MaxRequestBodyBytes limits how much request body data OpenAPI validation may read. + // Zero uses the default limit. + MaxRequestBodyBytes int64 `yaml:"max_request_body_bytes" json:"max_request_body_bytes,omitempty"` + } +) + +func (p *Plugin) Kind() string { + return Kind +} + +func (p *Plugin) CreateFilterFactory() (filter.HttpFilterFactory, error) { + return &FilterFactory{cfg: &Config{}}, nil +} + +func (factory *FilterFactory) Config() any { + return factory.cfg +} + +func (factory *FilterFactory) Apply() error { + path, err := cleanOpenAPIPath(factory.cfg.Path) + if err != nil { + return err + } + factory.cfg.Path = path + + maxRequestBody, err := factory.cfg.effectiveMaxRequestBodyBytes() + if err != nil { + return err + } + + validator, model, validationOptions, err := loadValidatorFromFile(path) + if err != nil { + return err + } + factory.validator = validator + factory.model = model + factory.validationOptions = validationOptions + factory.maxRequestBody = maxRequestBody + return nil +} + +func (factory *FilterFactory) PrepareFilterChain(ctx *contexthttp.HttpContext, chain filter.FilterChain) error { + f := &Filter{ + validator: factory.validator, + model: factory.model, + validationOptions: factory.validationOptions, + maxRequestBody: factory.maxRequestBody, + } + chain.AppendDecodeFilters(f) + return nil +} + +func (f *Filter) Decode(ctx *contexthttp.HttpContext) filter.FilterStatus { + if f.validator == nil || f.model == nil { + return filter.Continue + } + + req := ctx.Request + pathItem, foundPath, ok := f.findRequestOperation(req) + if !ok { + return filter.Continue + } + + if err := f.prepareRequestBodyForValidation(req); err != nil { + if err == errOpenAPIRequestBodyTooLarge { + errResp := contexthttp.PayloadTooLarge.WithError(err) + ctx.SendLocalReply(errResp.Status, errResp.ToJSON()) + logger.Debug(errResp.Error()) + return filter.Stop + } + errResp := contexthttp.BadRequest.WithError(errors.New("openapi request body read failed")) + ctx.SendLocalReply(errResp.Status, errResp.ToJSON()) + logger.Debugf("openapi request body read failed: %v", err) + return filter.Stop + } + + if valid, validationErrs := f.validator.ValidateHttpRequestSyncWithPathItem(req, pathItem, foundPath); !valid { + validationDetails := formatValidationErrors(validationErrs) + errResp := contexthttp.BadRequest.WithError(errors.New("openapi request validation failed")) + ctx.SendLocalReply(errResp.Status, errResp.ToJSON()) + logger.Debugf("openapi request validation failed: %s", validationDetails) + return filter.Stop + } + return filter.Continue +} + +func (f *Filter) findRequestOperation(req *http.Request) (*v3.PathItem, string, bool) { + pathItem, validationErrs, foundPath := validatorPaths.FindPath(req, f.model, f.validationOptions) + if len(validationErrs) > 0 { + logger.Debugf("openapi path lookup errors for %s %s: %s", req.Method, req.URL.Path, formatValidationErrors(validationErrs)) + return nil, "", false + } + if pathItem == nil { + return nil, "", false + } + if !hasRequestOperation(req, pathItem) { + return nil, "", false + } + return pathItem, foundPath, true +} + +func hasRequestOperation(req *http.Request, pathItem *v3.PathItem) bool { + switch req.Method { + case http.MethodGet: + return pathItem.Get != nil + case http.MethodPost: + return pathItem.Post != nil + case http.MethodPut: + return pathItem.Put != nil + case http.MethodDelete: + return pathItem.Delete != nil + case http.MethodOptions: + return pathItem.Options != nil + case http.MethodHead: + return pathItem.Head != nil || pathItem.Get != nil Review Comment: 已修复。 `HEAD` 现在只接受显式声明的 `head` operation，不再 fallback 到 `GET`。这样只声明了 `GET` 的 `HEAD` 请求会按文档契约跳过校验，不会再被 GET 的 requestBody 或其它 operation 信息影响。 同时补了回归测试，明确覆盖 `HEAD` 必须显式声明 `head` operation 的行为。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
