leno23 opened a new pull request, #3383: URL: https://github.com/apache/dubbo-go/pull/3383
## What changed - Expanded the echo filter package comment to explain that `Echo` is a reserved built-in health check method name. - Documented that services should avoid business methods named `Echo` when the echo filter is enabled. - Kept runtime behavior unchanged. ## Why Issue #2084 reports a panic after defining a service named/methoded `Echo`; maintainers clarified that this is caused by conflict with dubbo-go's built-in echo filter behavior and is not a runtime bug. The package comment now makes that behavior explicit. Refs #2084 ## Validation - `gofmt -w filter/echo/filter.go` - `git diff --check` Note: `go test ./filter/echo` was not completed in this sparse checkout because `common/extension` pulls additional packages that are outside the current sparse tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
