Alanxtl commented on PR #3379:
URL: https://github.com/apache/dubbo-go/pull/3379#issuecomment-4648794151
Thanks for the patch, but I don't think this is the right direction.
The failure in #3142 is about `TestStreamForServer/client-stream-conn`
receiving `unknown: write envelope: EOF` after the server intentionally calls
`stream.Conn().Send("not-proto")`. That is a test scenario built around an
invalid server-side send, and the current PR only suppresses an unrelated
Alt-Svc warning for `:0`.
I don't think we should change framework behavior just to hide this warning.
The fix should first revisit the test expectation: after an invalid
`stream.Conn().Send("not-proto")`, it may not be valid to require the
client-side `CloseAndReceive` path to complete with nil in all environments. If
the goal is to verify invalid message handling, the test should assert the
actual error behavior more explicitly instead of depending on this stream
continuing cleanly.
So I think this PR should be reworked around the failing test / stream
expectation, not around skipping Alt-Svc header advertisement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
