Qiao-yq opened a new pull request, #3401: URL: https://github.com/apache/dubbo-go/pull/3401
Replace all config.Get*() calls in initClient and initServer with URL attribute reads, following the pattern already used by triple/grpc/dubbo3 protocols. The URL attributes (ProtocolConfigKey, TLSConfigKey, ApplicationKey) are already populated by callers in server/action.go and client/action.go, so the legacy config fallback path is redundant. Changes: - getty_client.go: replace config.GetApplicationConfig() / config.GetRootConfig().Protocols / config.GetRootConfig().TLSConfig with url.GetAttribute() reads. Collapse two redundant TLS blocks into one, fixing a copy-paste bug where srvConf was used instead of clientConf. Add IsClientTLSValid validation that was missing in the legacy TLS path. - getty_server.go: same config → URL attribute migration. - Imports: remove dubbo.apache.org/dubbo-go/v3/config and dubbo.apache.org/dubbo-go/v3, add common/config for EnsureApplicationAttribute. - Update stale comments referencing rootConfig. ### Description Fixes #3396 ### Checklist - [x] I confirm the target branch is `develop` - [x] Code has passed local testing - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
