RainYuY commented on code in PR #16299:
URL: https://github.com/apache/dubbo/pull/16299#discussion_r3401016310
##########
dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java:
##########
@@ -290,6 +290,14 @@ Invoker<?> getInvoker(Channel channel, Invocation inv)
throws RemotingException
boolean isStubServiceInvoke;
int port = channel.getLocalAddress().getPort();
String path = (String) inv.getObjectAttachmentWithoutConvert(PATH_KEY);
+ if (path == null) {
+ throw new RemotingException(
Review Comment:
Is non-serializable parameter really the only scenario that can make path
null here? In the normal Dubbo request format, the service path is
encoded/decoded before arguments, and DubboInvoker also sets PATH_KEY before
sending the request. So a null path seems more generally like missing/malformed
invocation metadata, custom codec/invocation behavior, or decode/protocol
incompatibility. Could we make this error message less specific than “Please
ensure all parameter types implement Serializable” to avoid another misleading
diagnosis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
