leno23 commented on PR #3387: URL: https://github.com/apache/dubbo-go/pull/3387#issuecomment-4698296640
Addressed the P1 DoUnsubscribe feedback. DoUnsubscribe now validates the event listener and the subscribed entry type before calling unsubscribeURLLocked, so error paths no longer close/remove the local subscription. I also added a regression test covering the nil event-listener path and verifying the subscription remains in the map and open. Local validation passes: go test ./registry/etcdv3 ./remoting/etcdv3, go test -race ./registry/etcdv3, go test -coverprofile=/tmp/etcdv3_fix.out ./registry/etcdv3, and git diff --check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
