xxs588 commented on PR #3378:
URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4700997718
1. DetailMessage 的格式化逻辑在 #396 构造器和这个 PR 的 newGenericException
里都写了一遍如果构造器那边已经负责设置 DetailMessage 的话,这边可以直接用构造器,避免两边维护同一套逻辑?
2. Copilot 提到的测试 case(wantDetailString 为空导致断言 Error() == "")这个是否需要补回来捏?
以上仅供参考
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]