leno23 opened a new pull request, #3418:
URL: https://github.com/apache/dubbo-go/pull/3418

   ## What
   - Skip old triple compat response attachments that cannot be represented as 
HTTP trailer values.
   - Keep string and []string attachments unchanged.
   - Add a regression test for bool attachment values.
   
   ## Why
   Issue #3093 reported that the old triple compat unary handler can panic when 
provider filters add internal attachments such as bool values. Those values 
should not fail the RPC response path just because they cannot be written as 
HTTP trailers.
   
   ## Validation
   - go test ./protocol/triple/triple_protocol
   - go test ./protocol/triple/...
   - git diff --check
   
   Fixes part of #3093


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to