leno23 opened a new pull request, #3423: URL: https://github.com/apache/dubbo-go/pull/3423
## What - Move the graceful shutdown `Setter` interface out of the legacy `config` package into `graceful_shutdown`. - Update both the new graceful shutdown runtime init and the legacy compat init to use the moved interface. - Keep the existing legacy `*config.ShutdownConfig` filter compatibility branch for the later cleanup step. ## Why Part of #3329 PR 3: shrink graceful shutdown dependencies on the legacy `config` package before the final config package removal. ## Verification - `go test ./graceful_shutdown ./filter/graceful_shutdown ./config` - `gofmt -w graceful_shutdown/setter.go graceful_shutdown/shutdown.go config/graceful_shutdown.go graceful_shutdown/shutdown_test.go` - `git diff --check` Note: I installed the repository-pinned `golangci-lint` version and started targeted lint for these packages, but the local run did not return diagnostics after more than a minute, so I stopped that local process and will rely on PR CI for the full lint gate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
