Aias00 commented on PR #979: URL: https://github.com/apache/dubbo-go-pixiu/pull/979#issuecomment-4716111832
## Regarding `github.com/golang/mock` as indirect dependency The `github.com/golang/mock v1.6.0 // indirect` entry in `go.mod` is required because it is pulled in transitively by upstream dependencies: ``` dubbo.apache.org/dubbo-go/v3 → github.com/golang/mock github.com/dubbogo/gost → github.com/golang/mock github.com/nacos-group/nacos-sdk-go/v2 → github.com/golang/mock ``` `go mod why` confirms the main module does not directly need it. It cannot be removed without the upstream libraries migrating first. This is expected and benign. ## Regarding mockgen regeneration Good point — `pkg/server/controls/mocks/mocks.go` is a hand-written mock (not generated by mockgen), so it will not be overwritten by regeneration. If mockgen is used in the future, the generator should indeed be updated to `go.uber.org/mock/mockgen`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
