leno23 commented on code in PR #3420: URL: https://github.com/apache/dubbo-go/pull/3420#discussion_r3434169563
########## cluster/router/affinity/router.go: ########## Review Comment: Fixed in 3ae1adc4. `Notify()` now returns when config-center gives an empty affinity rule, and `Process()` also ignores empty add/update events, so bootstrap static affinity rules are preserved. Added `TestAffinityRouteProcessEmptyDynamicRuleKeepsStaticConfig` for this case. Local validation: `go test ./cluster/router/affinity ./global ./config` and `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
