rohithvegesna commented on PR #16348:
URL: https://github.com/apache/dubbo/pull/16348#issuecomment-4755986227
✅ CI is now green — all checks pass (32/32) on `b02bb3329` after a re-run.
For reviewers: the earlier red check was a single flaky test — `Samples Test
(JobId 2, Java 8)` →
`BackpressureIT.testClientStreamWithDisableAutoRequestWithInitial`, which
failed on a 60s `AssertionError: Stream should complete within timeout`. The
job logs show the stream actually completed (`onCompleted` fired, `sent=30`)
roughly 60s before the latch timed out, so this is a timing flake in that
streaming sample rather than a regression.
This PR only changes the return value of `StringUtils.toBoolean("off")`,
whose production callers are all in the Triple REST / OpenAPI path
(`GeneralTypeConverter`, `AnnotationMeta`, `Helper`, `ConfigFactory`) — not the
gRPC streaming / back-pressure path. All unit and integration jobs passed, and
the re-run is fully green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
