zrlw commented on PR #16345:
URL: https://github.com/apache/dubbo/pull/16345#issuecomment-4785697336
> @zrlw , have been going through the PR , seen the changes made , tried to
run the changes locally,test the changes, and it worked,
> @Test
> void testGoawayCausesNoChannelFailure() throws Throwable {
> final AbstractConnectionClient connectionClient =
> connectionManager.connect(url, new DefaultPuHandler());
> Assertions.assertTrue(
> connectionClient.isAvailable(),
> "Precondition: connection should be available before GOAWAY"
> );
> io.netty.channel.Channel channelBeforeGoaway =
connectionClient.getChannel(true);
> NettyConnectionHandler handler = new NettyConnectionHandler(
> (AbstractNettyConnectionClient) connectionClient);
> handler.onGoAway(channelBeforeGoaway);
> io.netty.channel.Channel channelAfterGoaway =
connectionClient.getChannel(true);
> Assertions.assertNotNull(
> channelAfterGoaway,
> "Channel should NOT be null immediately after GOAWAY " +
> "— old channel should stay alive until new one is
ready"
> );
> await().atMost(Duration.ofSeconds(10))
> .until(() -> connectionClient.isAvailable());
> Assertions.assertTrue(
> connectionClient.isAvailable(),
> "Connection should be available after GOAWAY migration
completes"
> );
> connectionClient.close();
> }
> ```
>
> }
Created TripleGoAwayTest.java based on these codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
