Copilot commented on code in PR #991:
URL: https://github.com/apache/dubbo-go-pixiu/pull/991#discussion_r3479651244
##########
pkg/server/pixiu_start.go:
##########
@@ -129,7 +122,8 @@ func Start(bs *model.Bootstrap) {
server = NewServer()
server.initialize(bs)
server.Start()
- server.startWG.Wait()
+ // Block until shutdown (handled by signal in listener_manager.go which
calls os.Exit)
Review Comment:
The new comment implies shutdown is always handled by listener_manager.go
via os.Exit, but ListenerManager.gracefulShutdownInit() returns early when
shutdown timeout <= 0 (listener_manager.go:91-93). In that configuration
shutdown will rely on the OS default signal behavior instead. Consider updating
the comment to reflect both cases so it stays accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
