skt-shinyruo commented on PR #16325: URL: https://github.com/apache/dubbo/pull/16325#issuecomment-4809387252
@oxsean Thanks for the review. I updated the PR in `7f4937f97d`. - The reflection path now throws `UnimplementedException` for ambiguous 2-method overloads instead of returning `null` and letting the caller NPE. - `parseRequestWrapper` no longer swallows parse failures, so corrupt wrappers now surface the decode error instead of falling back silently. - I also extracted the duplicated generic/echo lookup into a shared helper. Added regression tests for the ambiguous reflection-overload case and the corrupt-wrapper case, and re-ran `DescriptorUtilsTest` and `ReflectionPackableMethodTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
