chaojixinren opened a new pull request, #3460:
URL: https://github.com/apache/dubbo-go/pull/3460

   ### Description
   Fixes #3452
   
   Based on #3451 (remove old triple implementation). With old triple 
(`protocol/dubbo3`) removed, the `IDLMode` compatibility switch used to 
distinguish IDL / non-IDL mode is no longer needed. This PR removes it and 
keeps only the minimal mode semantics required by new Triple.
   
   Main changes:
   - Remove `IDLMode` / `IDL` / `NONIDL` constants and the related `WithIDL` / 
`WithIDLMode` options from client and server
   - Stop writing the `IDLMode` param onto the service URL
   - Simplify `TripleProtocol.Refer` to always use `NewTripleInvoker`, and drop 
the old-triple `NewDubbo3Invoker` path and the `isGenericCall` helper
   - Delete `protocol/triple/dubbo3_invoker.go`
   - Decide IDL vs non-IDL mode by the presence of `ServiceInfo` (`info != 
nil`) instead of the `IDLMode` URL param
   - Update related tests
   
   > Opened as a **draft** because it depends on #3451; the diff currently 
includes #3451's changes and will be rebased onto `develop` once #3451 is 
merged.
   
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature 
works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to