Copilot commented on code in PR #3470:
URL: https://github.com/apache/dubbo-go/pull/3470#discussion_r3533872475
##########
.github/workflows/riscv-build.yml:
##########
@@ -0,0 +1,47 @@
+name: RISC-V Build
+
+on:
+ push:
+ branches:
+ - main
+ - 'release-*'
+ - 'feature-*'
+ pull_request:
+ branches: "*"
+
Review Comment:
`pull_request.branches` should be a list (or omitted). Using a scalar string
(`"*"`) is not valid for the branches filter and can prevent the workflow from
triggering as intended.
##########
.github/workflows/github-actions.yml:
##########
@@ -28,28 +28,21 @@ jobs:
mode: check
CI:
- name: CI (${{ matrix.os }} - Go ${{ matrix.go_version }})
- runs-on: ${{ matrix.os }}
- strategy:
- # If you want to matrix build , you can append the following list.
- matrix:
- go_version:
- - '1.23'
- os:
- - ubuntu-latest
+ name: CI
+ runs-on: ubuntu-latest
steps:
- - name: Setup Go ${{ matrix.go_version }}
- uses: actions/setup-go@v5
- with:
- go-version: ${{ matrix.go_version }}
-
- name: Checkout
- uses: actions/checkout@v4
+ uses: actions/checkout@v7
+
+ - name: Setup Go
+ uses: actions/setup-go@v6
Review Comment:
In the `CI` job, the step entries are not indented under `steps:` (the `-
name:` lines must be nested under `steps`). As written, this is invalid
workflow YAML and will fail to load.
##########
.github/workflows/riscv-build.yml:
##########
@@ -0,0 +1,47 @@
+name: RISC-V Build
+
+on:
+ push:
+ branches:
+ - main
+ - 'release-*'
+ - 'feature-*'
+ pull_request:
+ branches: "*"
+
+permissions:
+ contents: read
+
+jobs:
+ RISC-V-Build:
+ name: RISC-V Build (linux/riscv64)
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v7
+
+ - name: Setup Go
Review Comment:
The `steps` list items are not indented under `steps:`. This makes the
workflow YAML invalid (the `- name:` entries become siblings of `steps` instead
of list items).
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -21,7 +21,7 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@v4
+ uses: actions/checkout@v7
Review Comment:
The `steps` list items are not indented under `steps:` (the `- name:` line
should be nested). This makes the CodeQL workflow YAML invalid.
##########
.github/workflows/github-actions.yml:
##########
@@ -78,28 +71,21 @@ jobs:
verbose: true # optional (default = false)
Integration-Test:
- name: Integration Test (${{ matrix.os }} - Go ${{ matrix.go_version }})
- runs-on: ${{ matrix.os }}
- strategy:
- # If you want to matrix build , you can append the following list.
- matrix:
- go_version:
- - '1.23'
- os:
- - ubuntu-latest
+ name: Integration Test
+ runs-on: ubuntu-latest
steps:
- - name: Setup Go ${{ matrix.go_version }}
- uses: actions/setup-go@v5
- with:
- go-version: ${{ matrix.go_version }}
-
- name: Checkout
- uses: actions/checkout@v4
+ uses: actions/checkout@v7
+
+ - name: Setup Go
+ uses: actions/setup-go@v6
Review Comment:
In the `Integration-Test` job, the step entries are not indented under
`steps:`. This makes the workflow YAML invalid and the job will not run.
##########
.github/workflows/release-drafter.yml:
##########
@@ -20,6 +15,6 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
steps:
- - uses: release-drafter/release-drafter@v6 #NOSONAR
+ - uses: release-drafter/release-drafter@v7 #NOSONAR
Review Comment:
This PR is described as adding a RISC-V build CI flow, but it also changes
release drafting behavior (removes the `pull_request` trigger and upgrades the
release-drafter action). If this behavior change is intended, please reflect it
in the PR description; if not, restore the `pull_request` trigger so drafts
keep updating on PR events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
