AryamannSingh7 commented on PR #16356: URL: https://github.com/apache/dubbo/pull/16356#issuecomment-5020946024
Hi @EarthChen, @CrazyHZM — could either of you take a look at this one for the second approve? @zrlw reviewed and approved it on 10 July, and the PR is still on `status/wait for another approve`, so I think it just needs one more sign-off to go in. It's a small, self-contained fix: under a multi-registry setup with a weakly dependent registry (`check=false`) that's down at startup, the app fails to boot with an NPE instead of degrading gracefully. It's a regression — `3.2.0`–`3.2.4` start fine, `3.2.5`+ don't, tracing to the metrics line added in #12582. The change completes null-safety that was already half-present in `ListenerRegistryWrapper` and guards that one metrics lookup; no behaviour change when the registry is non-null. +46/-10 across 3 files, with `ListenerRegistryWrapperTest#testNullRegistryIsTolerated` reproducing the NPE without the fix. CI is green on the current `3.3` rebase. Full detail is in the description and [my earlier comment](https://github.com/apache/dubbo/pull/16356#issuecomment-4928458524). Happy to reshape it if you'd prefer the guard elsewhere (e.g. not wrapping a null registry in `RegistryFactoryWrapper` at all). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
