zrlw commented on code in PR #16390:
URL: https://github.com/apache/dubbo/pull/16390#discussion_r3619358619
##########
dubbo-maven-plugin/src/main/java/org/apache/dubbo/maven/plugin/aot/JavaExecutable.java:
##########
@@ -33,10 +33,17 @@ public class JavaExecutable {
private final File file;
+ private final String executablePath;
+
public JavaExecutable() {
String javaHome =
SystemPropertyConfigUtils.getSystemProperty(CommonConstants.SystemProperty.JAVA_HOME);
Assert.assertTrue(StringUtils.isNotEmpty(javaHome), "Unable to find
java executable due to missing 'java.home'");
this.file = findInJavaHome(javaHome);
+ try {
Review Comment:
why moving the codes from ```toString()``` to here, are you seriously?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
