AlexStocks commented on code in PR #3500: URL: https://github.com/apache/dubbo-go/pull/3500#discussion_r3630174758
########## client/client.go: ########## @@ -135,6 +135,19 @@ func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection // NewGenericService creates a GenericService for making generic calls without pre-generated stubs. // The referenceStr parameter specifies the service interface name (e.g., "org.apache.dubbo.samples.UserProvider"). // +// Defaults: +// - generic mode (generalization format): "true" (Map). Override with client.WithGenericType. +// - transport serialization: Hessian2. Override with client.WithSerialization. +// +// The generic mode and the transport serialization are two independent settings: +// the former decides how objects are generalized, the latter how they are encoded on +// the wire. Passing an unknown generic mode returns an error instead of silently +// falling back to the Map generalizer. +// +// Whether the "class" field is kept in Map (generic=true) results is controlled by +// the global "generic.include.class" configuration (default true). It only affects +// the Map generalizer and currently has no per-reference override. Review Comment: [P1] 当前实现与本 PR 勾选的 API 验收项不一致 这里明确写成 `generic.include.class` 仅支持全局配置、没有 per-reference override，当前 Head 也已经删除 `WithGenericIncludeClass`；但 PR 的 Changes 和 Acceptance criteria 仍声称已新增该 API，并将该验收项标记完成。#3472 可以选择不提供用户侧 API，但需要明确收缩 scope；否则按当前 PR 声明，这项需求仍未实现。请二选一：实现一条能实际传递到 MapGeneralizer 的 per-reference 配置链路并补行为测试，或同步修改 PR 描述/验收范围，明确本 PR 只保留全局配置。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
