Chiraggupta0 commented on issue #16387: URL: https://github.com/apache/dubbo/issues/16387#issuecomment-5048881339
Hi, I'd like to try working on this one. I dug into it a bit and wanted to ask about the approach before I start coding, since I don't want to break Spring 5 users. From what I can see, the problem is in two classes in dubbo-rest-spring - HandlerInterceptorAdapter and SpringMiscArgumentResolver - they both cast the request to javax.servlet.http.HttpServletRequest. On Spring 6 that's jakarta.servlet now, so it fails (both compiling and at runtime). I first thought I could just add a jakarta version of these classes like the JValidator/JValidatorNew pattern, but then I realized spring-webmvc 5 and 6 can't both be on the classpath at the same time, so that doesn't really work here. So I'm not sure which way you'd prefer - handling both javax and jakarta with reflection so it stays one module, or a separate module compiled against Spring 6, or just dropping Spring 5 support here. I didn't want to pick one and then find out you wanted a different approach. Could you let me know which direction you'd prefer? Then I'll implement it with tests. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
