Copilot commented on code in PR #3507:
URL: https://github.com/apache/dubbo-go/pull/3507#discussion_r3637572910
##########
protocol/triple/triple.go:
##########
@@ -151,7 +151,7 @@ func (tp *TripleProtocol) Refer(url *common.URL)
base.Invoker {
// Use NewTripleInvoker for:
// 1. New protoc-gen-go-triple stub code (has ClientInfoKey)
// 2. Non-IDL mode (IDLMode == NONIDL)
- // 3. Generic call (generic=true/gson/protobuf/protobuf-json)
+ // 3. Generic call (generic=true/gson/protobuf-json/bean, or legacy
protobuf)
Review Comment:
The code documents `generic=protobuf` as a legacy alias, but `Refer` passes
the original URL through unchanged. Downstream generic-mode handling (e.g.,
`filter/generic/util.go:isGeneric` / `getGeneralizer`) does not recognize
`protobuf`, so legacy configs may silently fall back to the default generalizer
instead of behaving like `protobuf-json`. To actually retain compatibility,
normalize `generic=protobuf` to `protobuf-json` early (or handle the alias
consistently elsewhere).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
