Alanxtl commented on code in PR #3502:
URL: https://github.com/apache/dubbo-go/pull/3502#discussion_r3643502284
##########
tools/benchmark/client/engine/engine.go:
##########
@@ -107,7 +107,7 @@ func (e *Engine) Stop() {
close(e.stopChan)
e.cancel()
e.wg.Wait()
- fmt.Println("[INFO] 压测完成")
+ fmt.Println("[INFO] benchmark completed")
Review Comment:
all of the output, use dubbo/gost/logger instead, see other files for
reference
##########
tools/benchmark/client/engine/engine.go:
##########
@@ -107,7 +107,7 @@ func (e *Engine) Stop() {
close(e.stopChan)
e.cancel()
e.wg.Wait()
- fmt.Println("[INFO] 压测完成")
+ fmt.Println("[INFO] benchmark completed")
Review Comment:
all of the output, use dubbogo/gost/logger instead, see other files for
reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
