Alanxtl commented on code in PR #3498:
URL: https://github.com/apache/dubbo-go/pull/3498#discussion_r3679044958
##########
protocol/dubbo/impl/hessian.go:
##########
@@ -328,7 +328,7 @@ func unmarshalResponseBody(body []byte, p *DubboPackage)
error {
}
}
- return perrors.WithStack(hessian.ReflectResponse(rsp,
response.RspObj))
+ return perrors.WithStack(hessian2.ReflectResponse(rsp,
response.RspObj))
Review Comment:
这个是不是也应该是hessian而不是hessian2
##########
protocol/dubbo3/dubbo3_protocol_test.go:
##########
@@ -85,7 +89,7 @@ func TestDubbo3UnaryService_GetReqParamsInterfaces(t
*testing.T) {
func subTest(t *testing.T, val, paramsInterfaces any) {
list := paramsInterfaces.([]any)
for k := range list {
- err := hessian.ReflectResponse(val, list[k])
+ err := hessian2.ReflectResponse(val, list[k])
Review Comment:
ditto
##########
protocol/grpc/grpc_invoker.go:
##########
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
