CAICAIIs commented on code in PR #3299:
URL: https://github.com/apache/dubbo-go/pull/3299#discussion_r3703858948
##########
global/http3_config.go:
##########
@@ -34,14 +38,97 @@ type Http3Config struct {
// ref:
https://quic-go.net/docs/http3/server/#advertising-http3-via-alt-svc
Negotiation bool `yaml:"negotiation" json:"negotiation,omitempty"`
- // TODO: add more params about http3
+ // KeepAlivePeriod defines how often to send keep-alive packets.
+ KeepAlivePeriod string `yaml:"keep-alive-period"
json:"keep-alive-period,omitempty"`
+
+ // MaxIdleTimeout defines the maximum idle timeout for QUIC connections.
+ MaxIdleTimeout string `yaml:"max-idle-timeout"
json:"max-idle-timeout,omitempty"`
+
+ // MaxIncomingStreams defines the maximum number of concurrent
bidirectional streams.
+ MaxIncomingStreams int64 `yaml:"max-incoming-streams"
json:"max-incoming-streams,omitempty"`
+
+ // MaxIncomingUniStreams defines the maximum number of concurrent
unidirectional streams.
+ MaxIncomingUniStreams int64 `yaml:"max-incoming-uni-streams"
json:"max-incoming-uni-streams,omitempty"`
+}
+
+func (t *Http3Config) UnmarshalJSON(data []byte) error {
Review Comment:
已删除，原来是为了兼容一个早版本里的一个未正式发布的 camelCase JSON 字段名
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
