Alanxtl commented on code in PR #3590:
URL: https://github.com/apache/dubbo-go/pull/3590#discussion_r3717020997
##########
Makefile:
##########
@@ -40,6 +41,12 @@ test: clean
GOTOOLCHAIN=go1.25.0+auto go test ./... -coverprofile=coverage.txt
-covermode=atomic
cd $(CLI_DIR) && GOTOOLCHAIN=go1.25.0+auto go test ./...
+# Run race detector on packages that start background goroutines in tests.
+# TestServiceDiscoveryRegistryUnRegister_Concurrent intentionally simulates a
+# data race, so it is excluded from the race detector via -skip.
+test-race:
+ GOTOOLCHAIN=go1.25.0+auto go test -race ./registry/servicediscovery/...
-skip '^TestServiceDiscoveryRegistryUnRegister_Concurrent$$'
+
Review Comment:
改成全局都运行-race吧 不要只运行servicediscovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
