XiaoFeiASK commented on PR #3594:
URL: https://github.com/apache/dubbo-go/pull/3594#issuecomment-5202609523

   已新增 `client/client_test.go` 回归测试:
   
   - 问题:缺少经过 `Client.NewGenericService(...)` 的主链路回归测试,无法证明 
`WithGenericType(...)` 的最终 generic 模式会同步到返回的 `GenericService`。
   - 修复:新增 `TestNewGenericServicePropagatesGenericTypeToTypedInvoke`,通过 
`NewGenericService(..., WithGenericType("gson"))` 创建服务,断言返回服务继承 `"gson"` 模式,并验证 
`InvokeWithType` 按 Gson 模式解析 typed result。
   - 影响:删除 `NewGenericService` 中 
`SetGenericType(connection.refOpts.Reference.Generic)` 同步逻辑时测试会失败,防止返回服务回退到默认 
Map 模式导致 typed result 解析错误。
   - 验证:`go test ./client ./filter/generic ./filter/generic/generalizer 
./internal -count=1`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to