Copilot commented on code in PR #140:
URL: https://github.com/apache/dubbo-getty/pull/140#discussion_r3740198330
##########
client.go:
##########
@@ -405,12 +397,13 @@ func (c *client) connect() {
c.Unlock()
ss.SetAttribute(sessionClientKey, c)
ss.SetAttribute(ignoreReconnectKey, false)
- break
+ return true
Review Comment:
`connect()` can break out when `c.ssMap == nil` (client stopping) without
closing the just-created session/connection, leaving an untracked session
running. Close the session before breaking out of that branch to avoid leaking
resources during shutdown races.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
