EmptyCity-111 commented on code in PR #3613:
URL: https://github.com/apache/dubbo-go/pull/3613#discussion_r3742831063
##########
global/protocol_config.go:
##########
@@ -31,20 +31,6 @@ type ProtocolConfig struct {
Params any `yaml:"params" json:"params,omitempty" property:"params"`
TripleConfig *TripleConfig `yaml:"triple" json:"triple,omitempty"
property:"triple"`
-
- // TODO: remove MaxServerSendMsgSize and MaxServerRecvMsgSize when
version 4.0.0
- //
- // MaxServerSendMsgSize max size of server send message,
1mb=1000kb=1000000b 1mib=1024kb=1048576b.
- // more detail to see
https://pkg.go.dev/github.com/dustin/go-humanize#pkg-constants
- //
- // Deprecated: use
"ClientProtocolConfig.TripleConfig.MaxServerSendMsgSize" or in config tag
"protocol_config/triple/max-server-send-msg-size" instead
- MaxServerSendMsgSize string `yaml:"max-server-send-msg-size"
json:"max-server-send-msg-size,omitempty"`
Review Comment:
@-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
