chaojixinren opened a new pull request, #1131:
URL: https://github.com/apache/dubbo-go-samples/pull/1131

   ## What this PR does
   
   Two small cleanups found while running the router samples locally:
   
   1. **router/condition/README.md & README_CN.md**: the port comments in the 
"Run server" section were swapped. The code actually uses `TriPort = 20001` in 
`go-server/cmd/server.go` and `TriPort = 20000` in 
`go-node2-server/cmd/server_node2.go`, which is the opposite of what the 
READMEs said.
   
   2. **router/tag/go-client/cmd/client.go**: removed a stale comment saying 
result checking was temporarily cancelled because apache/dubbo-go#3208 had not 
been merged — that PR was merged in February 2026.
   
   ## Verification
   
   - Ran both condition sample servers and confirmed the actual listening ports 
match the corrected comments (`lsof` on 20000/20001).
   - `go build ./router/tag/...` passes; no behavior change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to