xiaobaicai66695 commented on code in PR #3602:
URL: https://github.com/apache/dubbo-go/pull/3602#discussion_r3763370102
##########
metadata/report/zookeeper/report.go:
##########
@@ -89,6 +90,11 @@ type zookeeperMetadataReport struct {
url *common.URL
}
+// listAppRevisionsMaxConcurrency bounds the number of in-flight reads sent
+// over the ZooKeeper connection. ZooKeeper's Go client does not support read
+// operations in Multi, but concurrent requests are pipelined by the client.
+const listAppRevisionsMaxConcurrency = 16
Review Comment:
Addressed in 9d44eaed. Moved the concurrency limit to
`common/constant/default.go` as
`constant.ZookeeperListAppRevisionsMaxConcurrency` and updated both
implementation and tests. Verified with `make fmt`, `make check-fmt`, race
tests, metadata/service-discovery tests, repeated concurrency tests, and `go
vet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
