AlexStocks commented on code in PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#discussion_r3764623074
##########
protocol/triple/client.go:
##########
@@ -227,18 +228,22 @@ func newClientManager(url *common.URL) (*clientManager,
error) {
return nil, fmt.Errorf("TRIPLE http3 client must have
TLS config, but TLS config is nil")
}
- // HTTP/3 transport maps keepalive to quic-go's KeepAlivePeriod
and MaxIdleTimeout;
- // All other QUIC knobs keep the quic.Config defaults.
+ var http3Config *global.Http3Config
+ if tripleConf != nil {
+ http3Config = tripleConf.Http3
+ }
+ quicConfig, configErr := http3config.NewQUICConfig(http3Config,
&quic.Config{
Review Comment:
[P1] 这里的 `Http3Config` 映射仍没有接入用户实际启用 HTTP/3 的客户端路径。当前 `Http3.Enable=true` 会把
`callProtocol` 设为 `CallHTTP2AndHTTP3`，随后走 `newDualTransport`；这个 `CallHTTP3`
分支没有现有公开配置入口。public-entrypoint 探针把 `KeepAlivePeriod`
设为无效值后，`GetProtocol().Refer` 仍成功创建 dual transport，说明配置被静默忽略。请把 `Http3Config` 传入
`newDualTransport` 并用共享 mapper 构造其中的
`http3.Transport.QUICConfig`，再从公开入口覆盖显式字段和无效 duration。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
