MaoMengww opened a new pull request, #3657:
URL: https://github.com/apache/dubbo-go/pull/3657

   ### Description
   This PR improves the comments and test coverage of metadata/options.go.
   - Comments the Options and ReportOptions types, including their fields — 
appName, metadataType (local/remote), protocol, port, address, registryId, 
params, and the embedded MetadataReportConfig and so on.
   - Refactors the option tests to table-driven subtests (TestNewOptions, 
TestNewReportOptions)
   Refs https://github.com/apache/dubbo-go/issues/3644 (task6)
   
   本地验证
   ```
   ~/project/dubbo-go$ go test ./metadata/...
   ok      dubbo.apache.org/dubbo-go/v3/metadata   0.092s
   ok      dubbo.apache.org/dubbo-go/v3/metadata/info      (cached)
   ?       dubbo.apache.org/dubbo-go/v3/metadata/mapping   [no test files]
   ok      dubbo.apache.org/dubbo-go/v3/metadata/mapping/metadata  0.016s
   ok      dubbo.apache.org/dubbo-go/v3/metadata/report    (cached)
   ok      dubbo.apache.org/dubbo-go/v3/metadata/report/etcd       (cached)
   ok      dubbo.apache.org/dubbo-go/v3/metadata/report/nacos      (cached)
   ok      dubbo.apache.org/dubbo-go/v3/metadata/report/zookeeper  (cached)
   ?       dubbo.apache.org/dubbo-go/v3/metadata/triple_api/proto  [no test 
files]
   ```
   ### Checklist
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to