AlexStocks commented on code in PR #1133:
URL: https://github.com/apache/dubbo-go-samples/pull/1133#discussion_r3788484625
##########
.github/workflows/github-actions.yml:
##########
@@ -66,7 +66,7 @@ jobs:
run: |
set -euo pipefail
if [ "$GITHUB_EVENT_NAME" == "pull_request" ]; then
- BRANCH=${{ github.base_ref }}
Review Comment:
[P1] 这个仓库级 PR workflow 不能固定到一次性的 Dubbo commit
原逻辑用 github.base_ref，每个 samples PR 都会针对当时目标分支的 Dubbo 代码执行依赖替换；这里改成
b3adb336... 后，后续所有 PR 都会长期测试同一个旧 revision。即使 Dubbo 当前 base 已改变、样例已不再兼容，CI
仍可能保持绿色。请恢复动态 github.base_ref；如果本样例确实依赖尚未发布的特定提交，应只在该样例的临时专用
job/矩阵中表达，不能改变整个仓库未来 PR 的验证基线。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
