skt-shinyruo opened a new pull request, #16426: URL: https://github.com/apache/dubbo/pull/16426
## What is the purpose of the change? Fixes #13735. PR #13385 removed the unary observer overload from generated Triple service interfaces to avoid ambiguous method resolution. It also made the differently named async bridge abstract, which requires sync-only providers to implement a synthetic method that is not declared in their proto service. This change restores the default async bridge while keeping the observer overload out of the interface. Providers that explicitly implement the async method continue to override it as before. The regression test generates a unary service interface and compiles both a sync-only provider and a provider with an explicit async override. It also verifies that the observer overload removed by #13385 remains absent. ## Verification - `./mvnw -pl dubbo-plugin/dubbo-compiler test` - `./mvnw -pl dubbo-plugin/dubbo-compiler -DskipTests package` - `git diff --check` ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
