lizining1231 commented on code in PR #3669: URL: https://github.com/apache/dubbo-go/pull/3669#discussion_r3791787816
########## common/config/environment_race_test.go: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package config + +import ( + "sync" + "testing" +) + +// TestDynamicConfigurationRace verifies that concurrent SetDynamicConfiguration +// and GetDynamicConfiguration calls on the global Environment instance are +// race-free. It mirrors the CI flaky race where a registry subscription +// goroutine kept reading the field while a test goroutine wrote it. +func TestDynamicConfigurationRace(t *testing.T) { + env := GetEnvInstance() + previous := env.GetDynamicConfiguration() + t.Cleanup(func() { + env.SetDynamicConfiguration(previous) + }) + + const iterations = 100000 + var wg sync.WaitGroup + wg.Go(func() { // reader goroutine mimics a lingering registry subscription goroutine + for range iterations { + _ = env.GetDynamicConfiguration() + } + }) + for range iterations { // the test goroutine keeps writing + env.SetDynamicConfiguration(nil) + } + wg.Wait() Review Comment: Thanks for the review! You're right: without synchronization the read/write overlap depends on scheduler timing, so the pre-fix race reproduction remained probabilistic to some extent. I've applied your suggestion: - The reader now reports ready and blocks on a start gate. - The writer waits for the ready signal before beginning the 100k writes. - The concurrent access therefore always overlaps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
