Alanxtl commented on PR #3668: URL: https://github.com/apache/dubbo-go/pull/3668#issuecomment-5312960029
> > > I ve seen it,casuse the intergration-test never use the function `SendHeader`,so it can not test this bug, if u use the `SendHeader`in the test https://github.com/apache/dubbo-go-samples/blob/main/triple_header_trailer/go-server/cmd/main.go line 55, the panic will happen in https://github.com/apache/dubbo-go-samples/blob/main/triple_header_trailer/go-client/cmd/main.go line 63, and it would cause the requestheader be polluted. > > > > > > But the integration test clearly runs `SendHeader` on line 55 of https://github.com/apache/dubbo-go-samples/blob/main/triple_header_trailer/go-server/cmd/main.go. The integration test will run it automatically. > > Can you please help us create a pr to dubbo-go-samples to fix the integration test > > Thk! Just a small clarification — line 55 is calling SetHeader, not SendHeader. I think there might be a minor oversight. Could u please take another look? <img alt="image" width="1121" height="88" src="https://private-user-images.githubusercontent.com/255077589/636830367-24669683-6bb2-4d5c-bfd2-0d3e730fdd4c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODY5NTA5NjksIm5iZiI6MTc4Njk1MDY2OSwicGF0aCI6Ii8yNTUwNzc1ODkvNjM2ODMwMzY3LTI0NjY5NjgzLTZiYjItNGQ1Yy1iZmQyLTBkM2U3MzBmZGQ0Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwODE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDgxN1QwNzExMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOGFlOGZkODIyN2Y0NzVhODM5NDBhMzliNjMwY2E2YTgwZTEzNjNkY2QwNTBlY2E5OGNmYzI3MTkzMmY2ZjgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.WyD5O CulXcUElqQwAmkxZvvc-8dDa_MUnJqicmKUIBM"> okay, my mistake 😂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
