DaWesen opened a new pull request, #3676:
URL: https://github.com/apache/dubbo-go/pull/3676

   ### Description
   
   This PR improves the comments and test coverage of the service discovery 
instance customizers.
   
   - Adds doc comments to hostPortCustomizer, tagCustomizer, and the 
exported/subscribed revision customizers, explaining how host/port, tag, and 
revision affect the instance info registered to the registry.
   - Fixes the wrong Customize comment in 
service_instance_host_port_customizer.go (was copied from the revision 
customizer).
   - Adds unit tests for host/port writing covering: port already set, nil 
service metadata, no exported URLs, first-URL-only, unparsable port, and 
non-DefaultServiceInstance.
   
   Refs `https://github.com/apache/dubbo-go/issues/3644`  (task5)
   
   ### 本地验证
   
   ```
   ~/project/dubbo-go$ go test ./registry/servicediscovery/customizer/...
   ok      dubbo.apache.org/dubbo-go/v3/registry/servicediscovery/customizer    
  (cached)
   ```
   
   ### Checklist
   
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to