Alanxtl commented on code in PR #3680:
URL: https://github.com/apache/dubbo-go/pull/3680#discussion_r3804703604
##########
filter/generic/service_filter.go:
##########
@@ -76,10 +76,18 @@ func (f *genericServiceFilter) Invoke(ctx context.Context,
invoker base.Invoker,
}
// get real invocation info from the generic invocation
- mtdName := inv.Arguments()[0].(string)
+ // IsGenericInvocation only guarantees len(Arguments)==3, not the
element types;
+ // guard the assertions so a malformed $invoke returns an error instead
of panicking.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
