Alanxtl commented on code in PR #3505:
URL: https://github.com/apache/dubbo-go/pull/3505#discussion_r3810521056


##########
filter/generic/generalizer/map.go:
##########
@@ -249,7 +249,7 @@ func mapKey(key reflect.Value) any {
 // setInMap sets the struct into the map using the tag or the name of the 
struct as the key
 func setInMap(m map[string]any, structField reflect.StructField, value any) 
(result map[string]any) {
        result = m
-       if tagName := structField.Tag.Get("m"); tagName == "" {

Review Comment:
   我发现这里m还不能改为mapstructure 会影响下游用户 还是改回来吧 不好意思😂



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to